Improved javascript regex regocnizing for extracting js messages#791
Open
gitaarik wants to merge 3 commits intopython-babel:masterfrom
Open
Improved javascript regex regocnizing for extracting js messages#791gitaarik wants to merge 3 commits intopython-babel:masterfrom
gitaarik wants to merge 3 commits intopython-babel:masterfrom
Conversation
Contributor
Author
|
Hi @akx, have you had time to look at this? It would be nice if this can be merged. |
akx
requested changes
Jan 28, 2022
Member
akx
left a comment
akx
left a comment
There was a problem hiding this comment.
Beyond the other comments, I'd appreciate tests showing how this improves parsing for the files previously accepted :)
Contributor
Author
|
Hey @akx , could you please give me some guidance about how/where I should add unit tests for this? I haven't found clear documentation about this. |
gitaarik
force-pushed
the
javascript-lexer-regex-parse-fix
branch
from
c9baa67 to
be48522
Compare
gitaarik
force-pushed
the
javascript-lexer-regex-parse-fix
branch
from
be48522 to
fdcac82
Compare
Contributor
Author
|
@akx Got it now, I wasn't familiar with tox, but now I am, a little. I added the unit test: I would really appreciate it if this can be merged soon and that a new release could be made. Then the build process of our project can be greatly simplified :). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #791 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 25 25
Lines 4391 4391
=======================================
Hits 3944 3944
Misses 447 447 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I'm not completely understanding this Codecov result, and what, if anything, is wrong. |
LucasLefevre
added a commit
to odoo/o-spreadsheet
that referenced
this pull request
Jun 15, 2022
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791
robodoo
pushed a commit
to odoo/o-spreadsheet
that referenced
this pull request
Jun 24, 2022
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 closes #1444 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
fw-bot
pushed a commit
to odoo/o-spreadsheet
that referenced
this pull request
Jun 24, 2022
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 X-original-commit: df307ed
robodoo
pushed a commit
to odoo/o-spreadsheet
that referenced
this pull request
Jun 24, 2022
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 closes #1461 X-original-commit: df307ed Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
LucasLefevre
added a commit
to odoo/o-spreadsheet
that referenced
this pull request
Jun 24, 2022
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791
robodoo
pushed a commit
to odoo/o-spreadsheet
that referenced
this pull request
Jun 24, 2022
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 closes #1462 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
fw-bot
pushed a commit
to odoo/o-spreadsheet
that referenced
this pull request
Jun 24, 2022
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 X-original-commit: d711ad2
fw-bot
pushed a commit
to odoo/o-spreadsheet
that referenced
this pull request
Jun 24, 2022
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 X-original-commit: d711ad2
fw-bot
pushed a commit
to odoo/o-spreadsheet
that referenced
this pull request
Jun 24, 2022
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 X-original-commit: d711ad2
robodoo
pushed a commit
to odoo/o-spreadsheet
that referenced
this pull request
Jun 24, 2022
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 closes #1465 X-original-commit: d711ad2 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
robodoo
pushed a commit
to odoo/o-spreadsheet
that referenced
this pull request
Jun 24, 2022
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 closes #1464 X-original-commit: d711ad2 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
robodoo
pushed a commit
to odoo/o-spreadsheet
that referenced
this pull request
Jun 24, 2022
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 closes #1463 X-original-commit: d711ad2 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
|
@akx Is what you requested done now? can this be merged? |
ScriptSavior57
added a commit
to ScriptSavior57/o-spreadsheet
that referenced
this pull request
Nov 18, 2024
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 closes odoo/o-spreadsheet#1461 X-original-commit: df307ed6a0e79370a8405b902df1e909671fb035 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
ScriptSavior57
added a commit
to ScriptSavior57/o-spreadsheet
that referenced
this pull request
Nov 18, 2024
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 closes odoo/o-spreadsheet#1464 X-original-commit: d711ad2cb1ef220d8a02853243859a4572748d61 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
ScriptSavior57
added a commit
to ScriptSavior57/o-spreadsheet
that referenced
this pull request
Nov 18, 2024
There's an issue in odoo when extracing translatable source terms from the bundled library file `o_spreadsheet.js`. Some terms are not extracted. Babel doesn't correctly tokenize the regex /"/ As a result, all following tokens are fucked up and source terms are no longer exported after this point. It seems to be known that babel js lexer isn't perfect. python-babel/babel#467 python-babel/babel#616 python-babel/babel#640 python-babel/babel#791 closes odoo/o-spreadsheet#1463 X-original-commit: d711ad2cb1ef220d8a02853243859a4572748d61 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a JS library that I use, there was regex with a
/inside a character class[a-z]. The babel JS lexer thought this closed the regex, but JavaScript allows this as a normal match character within a character class, and does not close the regex. I updated the regex so that it will cover this exception.This could also possibly fix these issues, or set the stage for further improvements regarding these issues:
How do I add unit tests for this? I haven't found clear documentation about this.